Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't simplify type of serialized return #1050

Merged
merged 3 commits into from
Mar 13, 2023
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

nuxt/nuxt#19654

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

We are experiencing issue comparing routes triggered by #1002. This slightly decreases complexity but we really need to find a solution for this on larger projects. (And ideally to replicate regression locally in type fixture by, as a first step, enabling strict: true in nitro and increasing type complexity.)

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Mar 13, 2023
@danielroe danielroe requested a review from pi0 March 13, 2023 22:31
@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Merging #1050 (62d028d) into main (21b2d65) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1050      +/-   ##
==========================================
- Coverage   67.41%   67.32%   -0.10%     
==========================================
  Files          62       62              
  Lines        6286     6283       -3     
  Branches      707      706       -1     
==========================================
- Hits         4238     4230       -8     
- Misses       2034     2038       +4     
- Partials       14       15       +1     
Impacted Files Coverage Ξ”
src/types/fetch.ts 100.00% <100.00%> (ΓΈ)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0 pi0 merged commit b167c62 into main Mar 13, 2023
@pi0 pi0 deleted the fix/nonnullable-response branch March 13, 2023 22:38
@pi0
Copy link
Member

pi0 commented Mar 13, 2023

Thanks! Feel free to open a followup issue to assign :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants