-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dedup unstorage
dependency and use subpath alias
#1164
Conversation
unstorage
dependencyunstorage
dependency and use subpath alias
Need to test more |
Codecov Report
@@ Coverage Diff @@
## main #1164 +/- ##
==========================================
- Coverage 76.58% 76.53% -0.05%
==========================================
Files 70 70
Lines 7182 7193 +11
Branches 714 714
==========================================
+ Hits 5500 5505 +5
- Misses 1681 1686 +5
- Partials 1 2 +1
|
Do you have an example reproduction? |
Unofrountaly not a stable one but this has been reported many times, especially within the Nuxt ecosystem. I am thinking to move it forward since this way of aliasing is better anyway by not pre-applying resolve conditions. |
π Linked issue
β Type of change
π Description
Similar to other core deps (h3, radix3, defu), unstorage should be deduped otherwise there might be missing chunks in final output (this is not root cause but a common issue and this PR is basically a stable workaround to the issue)
π Checklist