Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: config hmr support for routeRules and rutimeConfig #1175

Merged
merged 4 commits into from
Apr 19, 2023
Merged

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Apr 19, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR supports HMR config updates for runtimeConfig and routeRules objects for nitro dev to rebuild the app without full reload.

A manual hook nitro.updateConfig() is also exposed to update this configuration on demand programmatically (useful for integration with other frameworks like Nuxt)

image

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0
Copy link
Member Author

pi0 commented Apr 19, 2023

Early merging to try and improve on edge channel

@pi0 pi0 merged commit b320208 into main Apr 19, 2023
@pi0 pi0 deleted the feat/config-hmr branch April 19, 2023 19:02
@pi0 pi0 mentioned this pull request Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant