Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bun): resolve internal dependencies with bun export condition #1313

Merged
merged 2 commits into from
Jun 16, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Jun 16, 2023

🔗 Linked issue

❓ Type of change

Currently bun preset is broken since after unjs/ofetch#246, unjs/node-fetch-native#75 and unjs/uncrypto@abf5508, new bun export condition is used but we still trace the externals of ofetch/node-fetch-native/uncrypto with node condition.

This PR uses a workaround to resolve this.

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 changed the title chore: fix ci chore: fix bun ci Jun 16, 2023
@pi0 pi0 changed the title chore: fix bun ci fix(bun): resolve internal dependencies with bun export condition Jun 16, 2023
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #1313 (43719b0) into main (1a497c4) will increase coverage by 0.03%.
The diff coverage is 93.82%.

@@            Coverage Diff             @@
##             main    #1313      +/-   ##
==========================================
+ Coverage   76.89%   76.93%   +0.03%     
==========================================
  Files          68       68              
  Lines        6829     6845      +16     
  Branches      693      685       -8     
==========================================
+ Hits         5251     5266      +15     
  Misses       1577     1577              
- Partials        1        2       +1     
Impacted Files Coverage Δ
src/presets/netlify.ts 77.97% <66.66%> (ø)
src/presets/vercel.ts 94.03% <75.00%> (ø)
src/build.ts 85.12% <84.61%> (-0.10%) ⬇️
src/rollup/config.ts 88.67% <97.50%> (-0.92%) ⬇️
src/options.ts 94.33% <100.00%> (+0.01%) ⬆️
src/presets/bun.ts 100.00% <100.00%> (ø)
src/types/nitro.ts 100.00% <100.00%> (ø)
src/utils/index.ts 74.02% <100.00%> (ø)

... and 1 file with indirect coverage changes

@pi0 pi0 marked this pull request as ready for review June 16, 2023 09:39
@pi0 pi0 merged commit c24e1f8 into main Jun 16, 2023
@pi0 pi0 deleted the chore/bun-ci branch June 16, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant