Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: import NitroRuntimeHooks from runtime dir #1328

Merged
merged 1 commit into from
Jun 21, 2023
Merged

fix: import NitroRuntimeHooks from runtime dir #1328

merged 1 commit into from
Jun 21, 2023

Conversation

danielroe
Copy link
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

We need to import from the local runtime directory as ../types relative path doesn't exist in build/distributed package

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Jun 21, 2023
@danielroe danielroe requested a review from pi0 June 21, 2023 09:08
@danielroe danielroe self-assigned this Jun 21, 2023
@pi0 pi0 merged commit 798180f into main Jun 21, 2023
@pi0 pi0 deleted the fix/type-import branch June 21, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees

@danielroe danielroe

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielroe @pi0