Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generate types for #imports #1329

Merged
merged 2 commits into from
Jun 21, 2023
Merged

fix: generate types for #imports #1329

merged 2 commits into from
Jun 21, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

With new support for importing from #imports, we want to ensure we have type support for it.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Jun 21, 2023
@danielroe danielroe requested a review from pi0 June 21, 2023 14:19
@danielroe danielroe self-assigned this Jun 21, 2023
src/build.ts Show resolved Hide resolved
src/build.ts Show resolved Hide resolved
@pi0 pi0 changed the title fix: generate types for #imports fix: generate types for #imports Jun 21, 2023
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #1329 (1ded93a) into main (798180f) will increase coverage by 0.02%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main    #1329      +/-   ##
==========================================
+ Coverage   76.54%   76.57%   +0.02%     
==========================================
  Files          70       70              
  Lines        7121     7130       +9     
  Branches      706      708       +2     
==========================================
+ Hits         5451     5460       +9     
  Misses       1669     1669              
  Partials        1        1              
Impacted Files Coverage Ξ”
src/build.ts 85.52% <75.00%> (+0.29%) ⬆️

@pi0 pi0 merged commit 25b9c5c into main Jun 21, 2023
@pi0 pi0 deleted the fix/imports-types branch June 21, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants