Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid doubly-bundling runtime types #1334

Merged
merged 7 commits into from
Jun 21, 2023
Merged

fix: avoid doubly-bundling runtime types #1334

merged 7 commits into from
Jun 21, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

At the moment we are bundling two copies of various runtime types, one in the main nitropack index.d.ts and another in the runtime directory. The danger with this is that types can get out of sync when extending one of those two.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Jun 21, 2023
@danielroe danielroe requested a review from pi0 June 21, 2023 16:36
@danielroe danielroe self-assigned this Jun 21, 2023
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I am on phone trusting you already tested build)

@pi0
Copy link
Member

pi0 commented Jun 21, 2023

Can you please check failing ci?

@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #1334 (2435c08) into main (0145f01) will decrease coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1334      +/-   ##
==========================================
- Coverage   76.74%   76.64%   -0.10%     
==========================================
  Files          71       70       -1     
  Lines        7181     7151      -30     
  Branches      710      710              
==========================================
- Hits         5511     5481      -30     
  Misses       1669     1669              
  Partials        1        1              
Impacted Files Coverage Ξ”
src/types/index.ts 100.00% <ΓΈ> (ΓΈ)

... and 1 file with indirect coverage changes

@danielroe danielroe marked this pull request as ready for review June 21, 2023 19:34
@danielroe danielroe requested a review from pi0 June 21, 2023 19:43
@danielroe
Copy link
Member Author

previewing this and #1333 in nuxt/nuxt#21683.

we can confirm everything is passing before merging/releasing

@pi0 pi0 merged commit c5dd2a1 into main Jun 21, 2023
@pi0 pi0 deleted the fix/bundled-types branch June 21, 2023 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants