Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): enable router preemptive mode #1504

Merged
merged 2 commits into from
Jul 29, 2023
Merged

fix(app): enable router preemptive mode #1504

merged 2 commits into from
Jul 29, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Jul 29, 2023

  • add failing test
  • fix(app): enable router preemptive mode

πŸ”— Linked issue

Resolves #1503, nuxt/nuxt#22382

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codecov
Copy link

codecov bot commented Jul 29, 2023

Codecov Report

Merging #1504 (2d000dd) into main (c4c217a) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1504      +/-   ##
==========================================
- Coverage   76.25%   76.19%   -0.06%     
==========================================
  Files          73       73              
  Lines        7453     7453              
  Branches      733      732       -1     
==========================================
- Hits         5683     5679       -4     
- Misses       1769     1772       +3     
- Partials        1        2       +1     

see 1 file with indirect coverage changes

@pi0 pi0 merged commit f603119 into main Jul 29, 2023
6 checks passed
@pi0 pi0 deleted the fix/preemptive-router branch July 29, 2023 09:12
Hebilicious pushed a commit to Hebilicious/nitro that referenced this pull request Jul 29, 2023
@pi0 pi0 mentioned this pull request Aug 4, 2023
@pi0 pi0 mentioned this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Main router should be in preemptive mode
1 participant