Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(externals): increase score for npm package name patterns to avoid breaking changes #1548

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Aug 7, 2023

πŸ”— Linked issue

#1429, nuxt/nuxt#22515

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR improves the scoring system for include/exclude patterns introduce in #1429 by giving a higher score to package names (nonabsolute paths without).

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 merged commit 888180b into main Aug 7, 2023
6 checks passed
@pi0 pi0 deleted the fix/external-score branch August 7, 2023 16:23
@pi0 pi0 mentioned this pull request Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant