Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable timing in debug mode #1577

Merged
merged 1 commit into from
Aug 15, 2023
Merged

feat: enable timing in debug mode #1577

merged 1 commit into from
Aug 15, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Feels like this might be a good default when debugging.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #1577 (0b22e8c) into main (12d0e47) will increase coverage by 0.00%.
Report is 3 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1577   +/-   ##
=======================================
  Coverage   76.00%   76.00%           
=======================================
  Files          74       74           
  Lines        7710     7711    +1     
  Branches      760      760           
=======================================
+ Hits         5860     5861    +1     
  Misses       1848     1848           
  Partials        2        2           
Files Changed Coverage Ξ”
src/options.ts 96.65% <100.00%> (+<0.01%) ⬆️

@@ -32,6 +32,7 @@ import { nitroImports } from "./imports";
const NitroDefaults: NitroConfig = {
// General
debug: isDebug,
timing: isDebug,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might as well have it in nitro-dev preset (reason is that i am going to support non node dev experimental presets and timing feature is not that stable but can do later...)

@pi0 pi0 merged commit 6430ded into main Aug 15, 2023
8 checks passed
@pi0 pi0 deleted the feat/timing branch August 15, 2023 08:34
@pi0 pi0 mentioned this pull request Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants