Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use relative type path to nitro #internal/nitro #1584

Merged
merged 2 commits into from
Aug 15, 2023
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

#1560

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This uses relative path for #internal/nitro replacement in nitro-types.d.ts

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Aug 15, 2023
@danielroe danielroe self-assigned this Aug 15, 2023
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #1584 (a5b7a25) into main (b8b834f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1584   +/-   ##
=======================================
  Coverage   76.23%   76.24%           
=======================================
  Files          76       76           
  Lines        7789     7791    +2     
  Branches      776      776           
=======================================
+ Hits         5938     5940    +2     
  Misses       1849     1849           
  Partials        2        2           
Files Changed Coverage Ξ”
src/build.ts 84.23% <100.00%> (+0.05%) ⬆️

@misaon
Copy link

misaon commented Aug 15, 2023

Nice work!

@pi0 pi0 merged commit 5ffaa37 into main Aug 15, 2023
8 checks passed
@pi0 pi0 deleted the fix/relative-internal branch August 15, 2023 22:27
@pi0 pi0 mentioned this pull request Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants