Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: directly pass localFetch to route rules handler #1611

Merged
merged 1 commit into from
Aug 20, 2023
Merged

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Aug 20, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Fix regression with #1609 and netlify

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codecov
Copy link

codecov bot commented Aug 20, 2023

Codecov Report

Merging #1611 (23a1a2b) into main (e80752c) will decrease coverage by 0.02%.
Report is 2 commits behind head on main.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1611      +/-   ##
==========================================
- Coverage   76.56%   76.54%   -0.02%     
==========================================
  Files          76       76              
  Lines        7771     7773       +2     
  Branches      783      783              
==========================================
  Hits         5950     5950              
- Misses       1819     1821       +2     
  Partials        2        2              
Files Changed Coverage Ξ”
src/presets/firebase.ts 27.05% <0.00%> (-0.66%) ⬇️

@pi0 pi0 merged commit 5ca1462 into main Aug 20, 2023
7 of 8 checks passed
@pi0 pi0 deleted the fix/route-rule-proxy branch August 20, 2023 22:19
@pi0 pi0 mentioned this pull request Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant