Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly mark middleware: false for scanned routes #1631

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

A small typo seems to have crept in here.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Aug 25, 2023
@danielroe danielroe requested a review from pi0 August 25, 2023 08:36
@danielroe danielroe self-assigned this Aug 25, 2023
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #1631 (2a65c63) into main (175f6ae) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1631   +/-   ##
=======================================
  Coverage   77.73%   77.73%           
=======================================
  Files          76       76           
  Lines        7818     7818           
  Branches      799      799           
=======================================
  Hits         6077     6077           
  Misses       1739     1739           
  Partials        2        2           
Files Changed Coverage Ξ”
src/scan.ts 100.00% <100.00%> (ΓΈ)

@pi0 pi0 merged commit 6c67404 into main Aug 25, 2023
9 checks passed
@pi0 pi0 deleted the fix/middleware branch August 25, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants