Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(iis): merge web.config #1656

Closed
wants to merge 7 commits into from
Closed

fix(iis): merge web.config #1656

wants to merge 7 commits into from

Conversation

Hardaker587
Copy link
Contributor

🔗 Linked issue

Resolves #1628

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

@pi0 Adding additional functionality to #1436 in order to prevent breaking changes for those already integrated with IIS

Additional notes:

  • I will be adding in another PR, the functionality to generate the environment variables from runtimeConfigs.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@nuxt-studio
Copy link
Contributor

nuxt-studio bot commented Aug 28, 2023 •
edited
Loading

✅ Live Preview ready!

Name Edit Preview Latest Commit
nitro Edit on Studio ↗︎ View Live Preview 58a6bec

@Hardaker587 Hardaker587 mentioned this pull request Aug 28, 2023
Closed
1 task
pi0
pi0 reviewed Aug 28, 2023
View reviewed changes
CHANGELOG.md
@@ -2,55 +2,6 @@

All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.

## v2.6.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert changes in this file

@pi0
Copy link
Member

pi0 commented Aug 28, 2023

Thanks for the PR. Before i can make a review, can you please revert additional changes from PR? 🙏🏼

@pi0 pi0 changed the title Add in Web.config merge for IIS Presets fix(iss): merge web.comfig Aug 28, 2023
@pi0 pi0 changed the title fix(iss): merge web.comfig fix(iss): merge web.config Aug 28, 2023
@pi0 pi0 changed the title fix(iss): merge web.config fix(iis): merge web.config Aug 28, 2023
@Hardaker587 Hardaker587 deleted the iis branch August 28, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Merge pre-exisiting web.config iis_node
2 participants
@Hardaker587 @pi0