Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iis-node): pass PORT as NITRO_UNIX_SOCKET #1783

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Oct 3, 2023

πŸ”— Linked issue

resolves nuxt/nuxt#22961

(alternative rework of #1697 by @tidan-16)

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

iis-node runtime passes unix socket as PORT environment variable this makes issue for Nitro node listener (Note: this issue only related to iisnode, iis handler passes a valid port.)

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 changed the title fix(issnode): pass socket as port fix(issnode): pass PORT as NITRO_UNIX_SOCKET Oct 3, 2023
@pi0 pi0 changed the title fix(issnode): pass PORT as NITRO_UNIX_SOCKET fix(iss-node): pass PORT as NITRO_UNIX_SOCKET Oct 3, 2023
@pi0 pi0 changed the title fix(iss-node): pass PORT as NITRO_UNIX_SOCKET fix(iis-node): pass PORT as NITRO_UNIX_SOCKET Oct 3, 2023
@pi0 pi0 merged commit f5bb6b4 into main Oct 3, 2023
3 of 6 checks passed
@pi0 pi0 deleted the chore/fix-iisnode branch October 3, 2023 15:54
This was referenced Oct 3, 2023
@tolgahanbeyazoglu
Copy link

tolgahanbeyazoglu commented Dec 22, 2023

@pi0 The problem still persists on my IIS servers. need help
Operating System: Windows
Node Version: v21.5.0
Nuxt Version: 3.8.1
Nitro Version: 2.8.1

its true ?

export default defineNitroPlugin((nitroApp) => { process.env.NITRO_UNIX_SOCKET = process.env.PORT })

nitro: { plugins: ["~/nitroPlugins/unixsocket.ts"], },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

node-server.mjs breaks when using iisnode due to named pipe
2 participants