feat: add defineNitroErrorHandler type helper
#1923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having a named function presents it in stack traces to developers, clarifying that an error occurred within the default error handler itself.
- The description is extended to explain that the handler can be async - Update the example to use the `defineErrorHandler` definer function - Changed the implementation of the error handler to one that uses some of h3's functions.
An alphabetically sorted list is easier to find an entry in and easier to confirm an absence as well.
✅ Live Preview ready!
|
passionate-bram
changed the title
defineErrorHandler
|
Thanks! Maybe for consistency with type name we can name if decineNitroErrorHandler? |
As package maintainer the API (incl naming conventions) would be your decision / responsibility. |
pi0
changed the title
defineErrorHandler utildefineNitroErrorHandler util
pi0
changed the title
defineNitroErrorHandler utildefineNitroErrorHandler type helper
|
I see you added 355ea89 in order to reduce the size of the merge. I can rebase the other commit out as well, then it won't be in the history anymore |
Thanks no need we always squash :) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
#1922
❓ Type of change
📚 Description
defineErrorHandlerfunction that follows the definer pattern.defineErrorHandlerfunction in the auto-import list.errorHandleron the Configuration page, to use the new function.errorHandlerin a bit more detailThese changes are needed as described in #1922 I believe the "definer pattern" (I guess it is the factory pattern but the
defineXgives it a nice recognizable shape) is an important feature of nitro and provides good ergonomic value to users of the library.Please note that I made several smaller commits, feel free to pick and choose the changes to make it fit with the project as a whole.
Resolves #1922
📝 Checklist