Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(config): fix setResponseHeader example params #2027

Merged
merged 1 commit into from
Dec 25, 2023
Merged

Conversation

metowolf
Copy link
Contributor

πŸ”— Linked issue

none

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

https://github.com/unjs/h3/blob/53703dc860f1ff6fe7ce71d543deff1cfa810b11/src/utils/response.ts#L120

cause error

[nitro] [unhandledRejection] TypeError: Cannot read properties of undefined (reading 'res')
    at setResponseHeader (file:///data/workspace/node_modules/.pnpm/h3@1.9.0/node_modules/h3/dist/index.mjs:730:14)
    at file:///data/workspace/.nitro/dev/index.mjs:512:3
    at Object.onError (file:///data/workspace/.nitro/dev/index.mjs:552:14)
    at Server.toNodeHandle (file:///data/workspace/node_modules/.pnpm/h3@1.9.0/node_modules/h3/dist/index.mjs:1892:27)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link
Contributor

nuxt-studio bot commented Dec 25, 2023

βœ… Live Preview ready!

Name Edit Preview Latest Commit
nitro Edit on Studio β†—οΈŽ View Live Preview 65e5eca

@pi0 pi0 changed the title docs: fix setResponseHeader params docs(config): fix setResponseHeader example params Dec 25, 2023
@pi0 pi0 merged commit 8f0fccd into unjs:main Dec 25, 2023
@pi0 pi0 mentioned this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants