docs(cloudflare): update deployment guide #2074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Live Preview ready!
|
dario-piotrowicz
force-pushed
the
update-cloudflare-deploy-docs
branch
3 times, most recently
from
50187a4
to
c4ded8c
Compare
| @@ -300,26 +242,20 @@ NITRO_HELLO_THERE="captain" | |||
| SECRET="top-secret" | |||
| ``` | |||
|
|
|||
| ## Advanced | |||
| ## Cloudflare Bindings | |||
There was a problem hiding this comment.
Here I just included the Bindings and not the rest of the Cloudflare context (so the request and ctx object), I wonder if I should 🤔 (on one hand it would make these docs more comprehensive, on the other I wouldn't want to make these too overwhelming)
pi0
changed the title
dario-piotrowicz
force-pushed
the
update-cloudflare-deploy-docs
branch
from
c4ded8c
to
a86da6c
Compare
as part of these changes: - make the `cloudflare_pages` preset the recommended one - make the worker presets deprecated - give more information regarding Bindings
dario-piotrowicz
force-pushed
the
update-cloudflare-deploy-docs
branch
from
a86da6c
to
e7a51e1
Compare
pi0
reviewed
Jan 23, 2024
docs/content/2.deploy/0.index.md
Outdated
| @@ -27,19 +27,25 @@ When deploying to the production using CI/CD, Nitro tries to automatically detec | |||
| - [vercel](/deploy/providers/vercel) | |||
| - [zeabur](/deploy/providers/zeabur) | |||
|
|
|||
| ::alert{type="info"} | |||
| **Note:** Even with these presets, if you need to build your application locally (for development or testing purposes) targeting the provider environment, you still need to tell Nitro what preset it needs to use (you can see below how). | |||
There was a problem hiding this comment.
Preview is not applied for all presets so for now at least it cannot be a general advice
pi0
reviewed
Jan 23, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❓ Type of change
📚 Description
This PR updates the Cloudflare deployment docs by:
- making the
cloudflare_pagespreset the recommended one- making the worker presets deprecated
- giving more information regarding Bindings
- applying other cleanups
Besides the Cloudflare docs update this PR also includes small changes to the deployment overview doc to hopefully slightly clarify things