Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable scheduled tasks in testing environment #2200

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Feb 29, 2024

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This is a rather quick fix for the (experimental) scheduled tasks that if run in the testing environment, can cause tests to hang.

Later we might think of utils to emulate scheduled tasks within testing environment without making side-effects.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 marked this pull request as ready for review February 29, 2024 11:24
@pi0 pi0 merged commit ed8a3db into main Feb 29, 2024
@pi0 pi0 deleted the fix/close-crone branch February 29, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant