fix(openapi): use dynamic host + port #2216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi0
reviewed
Mar 4, 2024
src/runtime/routes/openapi.ts
Outdated
| @@ -9,6 +10,10 @@ import type { | |||
| import { handlersMeta } from "#internal/nitro/virtual/server-handlers"; | |||
| import { useRuntimeConfig } from "#internal/nitro"; | |||
|
|
|||
| // Currently, openapi is only available in dev, so there is no runtime difference to be determined here | |||
| const port = (destr(process.env.NITRO_PORT || process.env.PORT) || | |||
There was a problem hiding this comment.
The port can be still overriding with config, --port or as part of fallback.
We might retrieve it from headers inside event handler
There was a problem hiding this comment.
@pi0 done, I used the referer header to get it, so maybe it's a little more accurate
There was a problem hiding this comment.
Can we remove the ports inferred from environment variables, this will allow us to support more runtimes in the future ? (if running on production)
There was a problem hiding this comment.
Well, I found out that there is an easiest way 🤣🤣🤣
const url = getRequestURL(event).origin + baseThanks to h3
pi0
changed the title
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
#2215
❓ Type of change
📚 Description
Currently, openapi is only available in dev, so there is no runtime difference to be determined here 🥰
📝 Checklist