Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): do not override publicAssets in build #817

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

antfu
Copy link
Member

@antfu antfu commented Jan 9, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

There is a misalignment across dev and build. In dev, the middleware is registered in the normal order, which mean eailer items in publicAssets will have higher priority. While in build, fes.copy defaults to overrides the existing files, making the priority in the oppsite direction.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 merged commit a3492b0 into main Jan 9, 2023
@pi0 pi0 deleted the fix/public-assets-build branch January 9, 2023 11:18
pi0 pushed a commit that referenced this pull request Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants