ci: run tests against windows as well #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #837 +/- ##
==========================================
+ Coverage 70.40% 70.53% +0.13%
==========================================
Files 57 57
Lines 5295 5295
Branches 604 606 +2
==========================================
+ Hits 3728 3735 +7
+ Misses 1558 1552 -6
+ Partials 9 8 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Nice. With #782 I can confirm at leat the tests pass however the way we link modules using junction links is not portable. So it is false report almost. But I think we can accept it as a known limitation at least. Re etags, my guess is CRLF issue. Which could be fixed. |
pi0
added a commit
that referenced
this pull request
Jan 16, 2023
* ci: run tests against windows as well * ci: skip linting on windows * ci: run lint separately (so as not to block other tests) * test: adapt re for windows * add gitattrs for text files using lf * disable conflict test for now Co-authored-by: Pooya Parsa <pyapar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
β Type of change
π Description
There are some significant differences with windows, particularly around file URLs and absolute paths. This is a starting point to test nitro on Windows to catch these issues early.
Here are two key differences noticed so far:
cc: @pi0
π Checklist