Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(externals): support tracing orphan files in node_modules #865

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Jan 23, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

There are some files in node_modules without a parent package.json (perisma for example generates node_modules/.prisma without .prisma/package.json.

This PR supports tracing and copying them using a virtual package

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 changed the title feat(externals): support orphan files in node_modules feat(externals): support tracing orphan files in node_modules Jan 23, 2023
@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Merging #865 (05d7990) into main (63e250d) will decrease coverage by 0.02%.
The diff coverage is 94.59%.

@@            Coverage Diff             @@
##             main     #865      +/-   ##
==========================================
- Coverage   67.13%   67.12%   -0.02%     
==========================================
  Files          59       59              
  Lines        5785     5797      +12     
  Branches      614      616       +2     
==========================================
+ Hits         3884     3891       +7     
- Misses       1893     1897       +4     
- Partials        8        9       +1     
Impacted Files Coverage Ξ”
src/rollup/plugins/externals.ts 94.63% <94.59%> (+0.14%) ⬆️
src/rollup/config.ts 91.66% <0.00%> (-0.93%) ⬇️
src/utils/index.ts 51.30% <0.00%> (-0.53%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0 pi0 merged commit 6b65508 into main Jan 23, 2023
@pi0 pi0 deleted the fix/trace-orphan branch January 23, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants