Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vercel): allow non-glob cache rules to apply to / #908

Merged
merged 1 commit into from
Feb 4, 2023
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves #902

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Because of how the Vercel Build Output API works, we can't generate a file-only routing solution for a route rule that is /; in this very specific case we need to add it to the config as well.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Feb 3, 2023
@danielroe danielroe self-assigned this Feb 3, 2023
@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Merging #908 (5a185ab) into main (f7eed65) will decrease coverage by 0.09%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##             main     #908      +/-   ##
==========================================
- Coverage   67.50%   67.42%   -0.09%     
==========================================
  Files          59       59              
  Lines        5866     5878      +12     
  Branches      637      639       +2     
==========================================
+ Hits         3960     3963       +3     
- Misses       1897     1906       +9     
  Partials        9        9              
Impacted Files Coverage Ξ”
src/presets/vercel.ts 76.31% <25.00%> (-2.86%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0 pi0 merged commit 4d89e31 into main Feb 4, 2023
@pi0 pi0 deleted the fix/vercel-root branch February 4, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SWR routeRule on / doesn't work on Vercel
2 participants