Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cloudflare): pass params to kv request #138

Merged
merged 3 commits into from
Feb 6, 2023
Merged

fix(cloudflare): pass params to kv request #138

merged 3 commits into from
Feb 6, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • 🧹 Chore
  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Currently we spread the params within ofetch so we never actually end up passing any to the fetcher, meaning currently this (if the number of keys is high enough to warrant pagination) just requests the same list of keys over and over again until it times out.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working driver labels Feb 6, 2023
@danielroe danielroe requested a review from pi0 February 6, 2023 01:21
@danielroe danielroe self-assigned this Feb 6, 2023
@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Merging #138 (28f7031) into main (20cd2fd) will not change coverage.
The diff coverage is 50.00%.

❗ Current head 28f7031 differs from pull request most recent head 757948c. Consider uploading reports for the commit 757948c to get more accurate results

@@           Coverage Diff           @@
##             main     #138   +/-   ##
=======================================
  Coverage   89.93%   89.93%           
=======================================
  Files          15       15           
  Lines        1103     1103           
  Branches      262      262           
=======================================
  Hits          992      992           
  Misses        111      111           
Impacted Files Coverage Ξ”
src/drivers/cloudflare-kv-http.ts 84.61% <50.00%> (ΓΈ)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0
Copy link
Member

pi0 commented Feb 6, 2023

Can we fix params itself to be an object? It is used for L136 as well

@pi0 pi0 merged commit 7a5e387 into main Feb 6, 2023
@pi0
Copy link
Member

pi0 commented Feb 6, 2023

Thanks

@pi0 pi0 deleted the fix/cf-paging branch February 6, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working driver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants