Fix the benchmark README, add batch to the golang benchmark, and add wrk luas #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is extremely valuable, thank you for contributing! Merging this 🤗 I am now going through a major effort of refactoring the repository, to add some new functionality for more efficient handling of batch requests. I think it may help if you can spot the issue in the |
ashvardanian
approved these changes
Apr 15, 2024
|
🎉 This PR is included in version 0.5.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I cleaned up the readme in examples/login, updated the golang benchmark to add support for html and batching json requests, and added some .luas to be used with wrk for better benchmarking.
uring crashes constantly for me with kernel 6.0 so I've only run the posix engine which does not support pipelining.
@ashvardanian I also updated picohttpparser to use avx2 which is 2x faster for ucall, but that is not in this pull request. Feel free to point to it - it only requires that the buffer sizes be 64 byte multiples which should just work here.
If you accept this PR let me know if you want me to look at the uring code. I'm currently adding an io_uring event loop to python asyncio so it'd be fun to look at this as well.