Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added release.yml to generate release note automatically #134

Merged
merged 2 commits into from
Dec 15, 2022

Conversation

smellman
Copy link
Contributor

@smellman smellman commented Dec 8, 2022

Thank you for submitting a pull request!

Description

Added release.yml to generate release note automatically when create new release.

Type of Pull Request

  • Adding a feature
  • Fixing a bug
  • Maintaining documents
  • Others ()

Verify the followings

  • Code is up-to-date with the main branch
  • No build errors after npm run build
  • No lint errors after npm run lint
  • No errors on using charites help globally
  • Make sure all the existing features working well
  • Have you added at least one unit test if you are going to add new feature?
  • Have you updated documentation?

Refer to CONTRIBUTING.MD for more details.

Copy link
Contributor

@keichan34 keichan34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's create the required labels in https://github.com/unvt/charites/labels when we decide what labels we're going to use for automatically generated release notes

labels:
- ignore-for-release
authors:
- octocat
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this? :)

- title: Breaking Changes 🛠
labels:
- Semver-Major
- breaking-change
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should choose either semver-major/minor and breaking-change/enhancement and standardize the project around that instead of supporting both

@keichan34 keichan34 merged commit 455411d into unvt:main Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants