Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update @unvt/sprite-one to v0.0.8 #138

Merged
merged 1 commit into from
Dec 15, 2022
Merged

Update @unvt/sprite-one to v0.0.8 #138

merged 1 commit into from
Dec 15, 2022
+20 −8

Conversation

keichan34
Copy link
Contributor

Description

Update @unvt/sprite-one to v0.0.8 to fix unvt/sprite-one#11

Type of Pull Request

  • Adding a feature
  • Fixing a bug
  • Maintaining documents
  • Others ()

Verify the followings

  • Code is up-to-date with the main branch
  • No build errors after npm run build
  • No lint errors after npm run lint
  • No errors on using charites help globally
  • Make sure all the existing features working well
  • Have you added at least one unit test if you are going to add new feature?
  • Have you updated documentation?

champierre
champierre approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@champierre champierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keichan34 keichan34 merged commit 1695079 into unvt:main Dec 15, 2022
@keichan34 keichan34 deleted the update-sprite-one branch December 15, 2022 01:10
@keichan34 keichan34 added the enhancement New feature or request label Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@champierre champierre champierre approved these changes

@smellman smellman Awaiting requested review from smellman

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sprite.png cannot be generated properly when icons are only two
2 participants
@keichan34 @champierre