Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Windows to test matrix, update action versions #147

Merged
merged 7 commits into from
Dec 25, 2022
Merged

Add Windows to test matrix, update action versions #147

merged 7 commits into from
Dec 25, 2022

Conversation

keichan34
Copy link
Contributor

Description

Add Windows to the test matrix to make sure Charites works well on Windows

Type of Pull Request

  • Adding a feature
  • Fixing a bug
  • Maintaining documents
  • Others (CI)

Verify the followings

  • Code is up-to-date with the main branch
  • No build errors after npm run build
  • No lint errors after npm run lint
  • No errors on using charites help globally
  • Make sure all the existing features working well
  • Have you added at least one unit test if you are going to add new feature?
  • Have you updated documentation?

@keichan34 keichan34 marked this pull request as ready for review December 22, 2022 04:27
@keichan34 keichan34 linked an issue Dec 24, 2022 that may be closed by this pull request
Scheduled CI for building docs has no longer succeeded #148
Closed
yuiseki
yuiseki approved these changes Dec 24, 2022
View reviewed changes
Copy link
Member

@yuiseki yuiseki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked code diffs.

LGTM!!

@keichan34 keichan34 merged commit c910fe8 into unvt:main Dec 25, 2022
@keichan34 keichan34 deleted the add-windows-test branch December 25, 2022 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuiseki yuiseki yuiseki approved these changes

@JinIgarashi JinIgarashi JinIgarashi approved these changes

@champierre champierre Awaiting requested review from champierre

Assignees

@keichan34 keichan34

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scheduled CI for building docs has no longer succeeded
3 participants
@keichan34 @yuiseki @JinIgarashi