Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supports #73: add port option to serve command #92

Merged
merged 2 commits into from
Mar 5, 2022
Merged

Supports #73: add port option to serve command #92

merged 2 commits into from
Mar 5, 2022

Conversation

smellman
Copy link
Contributor

@smellman smellman commented Mar 5, 2022

Description

Supports #73
serve command enable to run custom port

Type of Pull Request

  • Adding a feature
  • Fixing a bug
  • Maintaining documents
  • Others ()

Verify the followings

  • Code is up-to-date with the main branch
  • No build errors after npm run build
  • No lint errors after npm run lint
  • No errors on using charites help globally
  • Make sure all the exsiting features working well
  • Have you updated documentation?

Refer to CONTRIBUTING.MD for more details.

@JinIgarashi JinIgarashi self-requested a review March 5, 2022 08:06
JinIgarashi
JinIgarashi approved these changes Mar 5, 2022
View reviewed changes
Copy link
Member

@JinIgarashi JinIgarashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
I also can see the issue of #43 for v1 was partially implemented now.

@JinIgarashi JinIgarashi linked an issue Mar 5, 2022 that may be closed by this pull request
Add charites serve supports multiple port #73
Closed
@JinIgarashi JinIgarashi merged commit 0f5d37c into unvt:main Mar 5, 2022
@JinIgarashi
Copy link
Member

@smellman I released it as v0.1.4 now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JinIgarashi JinIgarashi JinIgarashi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add charites serve supports multiple port
2 participants
@smellman @JinIgarashi