Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2 SDF icons support #21

Merged
merged 13 commits into from
Dec 10, 2023
Merged

#2 SDF icons support #21

merged 13 commits into from
Dec 10, 2023

Conversation

smellman
Copy link
Collaborator

@smellman smellman commented Dec 10, 2023 •
edited
Loading

@smellman smellman self-assigned this Dec 10, 2023
@smellman
Copy link
Collaborator Author

testing in local now...

@smellman
Copy link
Collaborator Author

スクリーンショット 2023-12-10 12 52 12 It seem OK.

JinIgarashi
JinIgarashi reviewed Dec 10, 2023
View reviewed changes
Copy link
Member

@JinIgarashi JinIgarashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks ok, commented few suggestions on documentation and about the buffer length setting.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/bin/index.ts Outdated Show resolved Hide resolved
src/lib/image.ts Show resolved Hide resolved
@smellman
Copy link
Collaborator Author

@JinIgarashi I fixes buffer issue now.

JinIgarashi
JinIgarashi reviewed Dec 10, 2023
View reviewed changes
Copy link
Member

@JinIgarashi JinIgarashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks great. I just commented a minor one

tests/fixtures/test1.json Outdated Show resolved Hide resolved
@smellman smellman changed the title #2 SDF icons support and add buffer between sprite #2 SDF icons support Dec 10, 2023
@smellman smellman merged commit 02c9a32 into main Dec 10, 2023
4 checks passed
@smellman smellman mentioned this pull request Dec 12, 2023
Closed
@smellman smellman deleted the dev-sdf branch December 12, 2023 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JinIgarashi JinIgarashi JinIgarashi approved these changes

Assignees

@smellman smellman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SDF icon option to generate sprite
2 participants
@smellman @JinIgarashi