fix: correctly handle DNS lookup on localhost, and fallback if needed #1140
+31
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is the following of #1136, this should work as the previous PR @helloanoop even though I did some refactoring.
what changed :
removed the connectivity cache if it fail, this allow handling edge case like :
added
dns.lookup
first if localhost resolve to a special IP, check the connectivity, and fallback to the custom handling if needed.Contribution Checklist: