Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set password manually when creating new user #1017

Merged
merged 10 commits into from
Jul 20, 2019

Conversation

amosfolz
Copy link
Contributor

I spread #fakenews about #764 and this feature was not actually implemented (sorry).

I forked the branch and resolved merge conflicts. Everything seems to checkout fine.

unplugged216 and others added 6 commits July 9, 2017 12:28
Refactored the modal 'user-set-password.html.twig'. Created 'forms/user-set-password.html.twig' and included it in the modal. Also created 'forms/partials/user-set-password.html.twig' to seperate the controls for setting the users password for reuse elsewhere.
When creating a user you can now set the password manually or force the user to create one. Previously an email was the only option and hindered the creation of a user if the email settings were not configured at all or incorrectly.
@codecov
Copy link

codecov bot commented Jul 12, 2019

Codecov Report

Merging #1017 into develop will decrease coverage by <.01%.
The diff coverage is 87.5%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1017      +/-   ##
=============================================
- Coverage         67%   66.99%   -0.01%     
- Complexity      1921     1923       +2     
=============================================
  Files            161      161              
  Lines           6700     6703       +3     
=============================================
+ Hits            4489     4491       +2     
- Misses          2211     2212       +1
Impacted Files Coverage Δ Complexity Δ
.../sprinkles/admin/src/Controller/UserController.php 99.59% <87.5%> (-0.2%) 112 <0> (+2)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 827ab6b...657aa0e. Read the comment docs.

@lcharette lcharette added this to the 4.3.0 milestone Jul 16, 2019
@lcharette lcharette merged commit ccf048e into userfrosting:develop Jul 20, 2019
@amosfolz amosfolz deleted the user-set-password branch July 20, 2019 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants