Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ls: Fix unknown IO error #6744

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

ls: Fix unknown IO error #6744

wants to merge 4 commits into from

Conversation

rulu158
Copy link

@rulu158 rulu158 commented Sep 27, 2024

From #6710 (explanation here).

@sylvestre
Copy link
Sponsor Contributor

please add a test to make sure we don't regress

sylvestre
sylvestre requested changes Sep 30, 2024
View reviewed changes
Copy link
Sponsor Contributor

@sylvestre sylvestre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a test

rulu158
rulu158 commented Oct 1, 2024
View reviewed changes
Copy link
Author

@rulu158 rulu158 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests added.

@sylvestre
Copy link
Sponsor Contributor

CICD / Build (ubuntu-latest, i686-unknown-linux-musl, feat_os_unix_musl, use-cross) (pull_request) Failing after 6m

one of the tests fails. Maybe just skip it for musl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sylvestre sylvestre sylvestre requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rulu158 @sylvestre