Don't use WrapperDescriptor and instead use Wrap/Unwrap APIs #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isheludko
pushed a commit
to isheludko/node
that referenced
this pull request
Jun 3, 2024
victorgomes
pushed a commit
that referenced
this pull request
Jun 3, 2024
pthier
pushed a commit
that referenced
this pull request
Jul 15, 2024
victorgomes
pushed a commit
that referenced
this pull request
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node has very basic support for wrapping objects and an experimental API to use
CppHeap(Oilpan).This PR switches the API to using
v8::Object::Wrap()andv8::Object::Unwrap()instead of using regular embedder fields.The PR is likely incomplete but enough to get basic tests to compile.
Also, the old apporach did distinguish between managed and unmanaged wrappers. Really, this distinction is gone as the new Wrap/Unrap APIs only support a single (the current)
CppHeap.