Merge pull request #1671 from mduesterhoeft/bugfix/map-traverse-perfo…

…rmance use a Vector as accumulator of map.traverse (#1633)
vavr-io · Nov 11, 2016 · a73d49f · a73d49f
2 parents b9f2263 + 662cdd7
commit a73d49f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/javaslang/src/main/java/javaslang/collection/Map.java b/javaslang/src/main/java/javaslang/collection/Map.java
@@ -543,7 +543,7 @@ default <U> U transform(Function<? super Map<K, V>, ? extends U> f) {
 
     default <U> Seq<U> traverse(BiFunction<K, V, ? extends U> mapper) {
         Objects.requireNonNull(mapper, "mapper is null");
-        return foldLeft(List.empty(), (acc, entry) -> acc.append(mapper.apply(entry._1, entry._2)));
+        return foldLeft(Vector.empty(), (acc, entry) -> acc.append(mapper.apply(entry._1, entry._2)));
     }
 
     default Tuple2<Seq<K>, Seq<V>> unzip() {

diff --git a/javaslang/src/main/java/javaslang/collection/Multimap.java b/javaslang/src/main/java/javaslang/collection/Multimap.java
@@ -455,7 +455,7 @@ default <U> U transform(Function<? super Multimap<K, V>, ? extends U> f) {
 
     default <U> Seq<U> traverse(BiFunction<K, V, ? extends U> mapper) {
         Objects.requireNonNull(mapper, "mapper is null");
-        return foldLeft(List.empty(), (acc, entry) -> acc.append(mapper.apply(entry._1, entry._2)));
+        return foldLeft(Vector.empty(), (acc, entry) -> acc.append(mapper.apply(entry._1, entry._2)));
     }
 
     default <T1, T2> Tuple2<Seq<T1>, Seq<T2>> unzip(BiFunction<? super K, ? super V, Tuple2<? extends T1, ? extends T2>> unzipper) {