Added a few methods to the public API of collections #1400
Conversation
| @@ -68,7 +61,7 @@ private Lazy(Supplier<? extends T> supplier) { | |||
| * @return the given {@code lazy} instance as narrowed type {@code Lazy<T>}. | |||
| */ | |||
| @SuppressWarnings("unchecked") | |||
| static <T> Lazy<T> narrow(Lazy<? extends T> lazy) { | |||
| public static <T> Lazy<T> narrow(Lazy<? extends T> lazy) { | |||
There was a problem hiding this comment.
There's no test for this
Current coverage is 97.22%@@ master #1400 diff @@
==========================================
Files 86 86
Lines 10282 10282
Methods 0 0
Messages 0 0
Branches 1823 1823
==========================================
Hits 9997 9997
Misses 157 157
Partials 128 128
|
| @@ -1841,14 +1840,14 @@ public int lastIndexOf(int ch, int fromIndex) { | |||
| * @param fromIndex the index to start the search from. | |||
| * @return {@code Some(index)} or {@code None} if not found. | |||
| */ | |||
| Option<Integer> lastIndexOfOption(int ch, int fromIndex) { | |||
| public Option<Integer> lastIndexOfOption(int ch, int fromIndex) { | |||
|
regarding the unfold* they were meant to be public. I missed it because I first added them to |
|
hmm wait this is static. Maybe the public would be needed also for interfaces like List then? (nope checked it actually no need for public even for static functions of an interface) |
Thanks :)
Interface methods can only be public, no need to specify it explicitly. |
|
Very nice! The branch has conflict now. Could you please solve them an I will merge. Thanks! |
|
Done, please recheck! |
|
Great, thank you! |
Fixes #1377