-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 3.5.1 -> 3.5.2 breaks meteor package with customized uniforms-unstyled #1001
Comments
No, it doesn't. I updated from 3.5.1. to 3.5.5. Things broke and then I went back and forth and narrowed it down to starting at 3.5.2 |
OK, it makes sense. We'll look into that soon. |
Hi @JanMP, thanks for pointing this out as it appears that we've introduced a regression. We're investigating and we'll keep you posted once we find something. |
I thought about it a little bit more and I'd say that we have to decide, whether we publish actual ES6 ES6 seems a valid choice, as it's already supported by all supported platforms. And if someone's bundler is down-leveling What do you think? @kestarumper In order to make sure that it'll work without problems in all major platforms, i.e., CRA, Gatsby, Meteor, please od check whether the |
just to add some information: 3.5.2 also breaks in nextjs (tried actually with 3.5.5). 3.5.1 works though |
@kestarumper Could you post your status here? I know you've checked something already. |
A few facts from my side. uniforms 3.5.5create-react-app
tsconfig{
"compilerOptions": {
"target": "es5",
"lib": [
"dom",
"dom.iterable",
"esnext"
],
"allowJs": true,
"skipLibCheck": true,
"esModuleInterop": true,
"allowSyntheticDefaultImports": true,
"strict": true,
"forceConsistentCasingInFileNames": true,
"noFallthroughCasesInSwitch": true,
"module": "esnext",
"moduleResolution": "node",
"resolveJsonModule": true,
"isolatedModules": true,
"noEmit": true,
"jsx": "react-jsx"
},
"include": [
"src"
]
} gatsby
tsconfig{
"compilerOptions": {
"outDir": "./dist/",
"sourceMap": true,
"noImplicitAny": true,
"module": "commonjs",
"target": "esnext",
"jsx": "react",
"lib": ["dom", "es2015", "es2017"]
},
"include": [
"./src/**/*"
]
} Right now I'm performing further tests on what might be the issue, and I'm trying to find a common solution. [UPDATE]I artificially forced your reproduction to use // node_modules/uniforms/package.json
...
"main": "./es5/index.js",
"module": "./es6/index.js",
...
[UPDATE 2]In the end, we created two builds targeting ES6 with CommonJS modules and ES6 modules. More on that in #1028. |
With Meteor 2.5.2 and Uniforms 3.7.0 everything works fine in the browser, but I get the error with Cordova (output from ios, android does not work either).
|
Hi @JanMP, sorry for the late response. As we're not using Codova ourselves anymore, we'd need a reproduction to confirm and fix that. Please do file a new issue with a reproduction. |
After updating I get the same error as #703
I only changed some of the fields. AutoForm is untouched.
Renaming _ to something else did not help.
Repro is here: https://github.com/JanMP/repro-uniforms-3.5.2-error (see two commits for changes that lead to problem)
The text was updated successfully, but these errors were encountered: