Removed props from Bridge.getProps
#1206
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request, I removed the second argument from
Bridge.getProps
, which is the same as we did withgetInitialValue
in #1185. The immediate benefit is that it becomes memoizable (and thus yields better performance), but also it wasn't really used for anything else than theoptions
/allowedValues
+transform
handling, which we'll move to the components anyway via #806. (If you'll read the tests I removed you'll see they weren't really helpful.)