Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added HTML5 input types to TextField #19

Merged
merged 3 commits into from
Jun 5, 2016

Conversation

serkandurusoy
Copy link
Contributor

@radekmie some input types were missing.

It would be best if we created proper inputs for them, but in the meantime, this quick override option should be able to serve most cases that don't need extra customization.

  • did not add a test for this since there is only tests for the base field.
  • tried to conform to the coding style of each component set.
  • also did a quick update on the readme.
  • incremented the version number to rc13

Let me know if this works for you.

@radekmie
Copy link
Contributor

radekmie commented Jun 5, 2016

That's neat, thanks! I'll merge it, but first:

  • remove checkInputType - it's unnecessary (optionally use propTypes instead)
  • reset version - lerna do it automatically, and it won't work if you update it by hand

@serkandurusoy
Copy link
Contributor Author

Done!

What do you think?

@radekmie
Copy link
Contributor

radekmie commented Jun 5, 2016

Great! One more question (because I can't do it right now) - are you passing npm run lint? If yes, I'll merge it in a minute.

@radekmie radekmie merged commit 36a1cff into vazco:master Jun 5, 2016
@serkandurusoy
Copy link
Contributor Author

hmm unfortunately the initial npm install hangs with lerna saying linking
all dependencies an it just freezes so I can't even try linting :(

Sent from my iPhone

On Jun 5, 2016, at 15:12, "Radosław Miernik" notifications@github.com
wrote:

Great! One more question (because I can't do it right now) - are you
passing npm run lint? If yes, I'll merge it in a minute.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#19 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AEbz3JCZ0WqbBcnxIV2WzkUnIlMsOmP9ks5qIr1BgaJpZM4IuVUl
.

@radekmie
Copy link
Contributor

radekmie commented Jun 5, 2016

It's not frozen (probably) - it just takes a while. Also, you can lint and test every single package.

@serkandurusoy
Copy link
Contributor Author

I get lots of very cryptic errors, seemingly unrelated to linting. I'll open an issue about "contribution guide"

@serkandurusoy
Copy link
Contributor Author

Thanks for merging! When do you plan on pushing the release?

@radekmie
Copy link
Contributor

radekmie commented Jun 5, 2016

Soon - I want to finish #17 first.

@serkandurusoy
Copy link
Contributor Author

Cool! Thanks.

On Sun, Jun 5, 2016 at 4:13 PM, Radosław Miernik notifications@github.com
wrote:

Soon - I want to finish #17 #17
first.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#19 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AEbz3Ey7yQscSXXaC9xvhFXJaPBUuaZGks5qIsuEgaJpZM4IuVUl
.

@radekmie radekmie added the Type: Feature New features and feature requests label Jun 8, 2016
@radekmie radekmie mentioned this pull request Jun 8, 2016
@radekmie radekmie changed the title Added html5 input types to text field Added HTML5 input types to TextField Sep 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New features and feature requests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants