[MTGOSDK/API] Client: Handle disposal when clearing client cache

videre-project · May 28, 2024 · 80d1b17 · 80d1b17
1 parent 0a0bce4
commit 80d1b17
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/MTGOSDK/src/API/Client.cs b/MTGOSDK/src/API/Client.cs
@@ -220,8 +220,11 @@ public Client(
   /// <summary>
   /// Cleans up any cached remote objects pinning objects in client memory.
   /// </summary>
-  public void ClearCaches()
+  /// <param name="disconnect">Whether to disconnect the client.</param>
+  public void ClearCaches(bool disconnect = false)
   {
+    if (disconnect) RemoteClient.Dispose();
+
     Log.Debug("Disposing all pinned remote objects registered with the client.");
     UserManager.Users.Clear();
     CollectionManager.Cards.Clear();
@@ -232,8 +235,7 @@ public void ClearCaches()
   /// </summary>
   public void Dispose()
   {
-    ClearCaches();
-    RemoteClient.Dispose();
+    ClearCaches(disconnect: true);
   }
 
   //