-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User/t mihir/enableprotection #8
base: recoveryservices-autorest-migration
Are you sure you want to change the base?
User/t mihir/enableprotection #8
Conversation
} | ||
$null = $PSBoundParameters.Add("CustomDetail", $ProviderDetail) | ||
$null = $PSBoundParameters.Remove("ProviderDetail") | ||
return Az.RecoveryServices.internal\New-AzRecoveryServicesReplicationFabric @PSBoundParameters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please return the job as output
) | ||
process { | ||
try { | ||
$protectionContainerString = $ProtectionContainer.id.Split("/") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add validation of not null or empty for Id
$null = $PSBoundParameters.Remove("ReplicationProtectedItem") | ||
$null = $PSBoundParameters.Add("FabricName", $fabricName) | ||
$null = $PSBoundParameters.Add("ProtectionContainerName", $protectionContainerName) | ||
$null = $PSBoundParameters.Add("ReplicatedProtectedItemName",$replicationProtectedItemName) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Return job Id
try { | ||
$fabricName = $ReplicationProtectedItem.PrimaryFabricFriendlyName | ||
$protectionContainerName = $ReplicationProtectedItem.Id.Split("/")[-3] | ||
$replicationProtectedItemName = $ReplicationProtectedItem.Name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check for instance type and throw exception if it's not supported
$null = $PSBoundParameters.Add("ProtectionContainerName", $protectionContainerName) | ||
$null = $PSBoundParameters.Add("ReplicatedProtectedItemName",$replicationProtectedItemName) | ||
$PSBoundParameters["NoWait"] = $true | ||
$res = Az.RecoveryServices.internal\Add-AzRecoveryServicesReplicationProtectedItemRecoveryPoint @PSBoundParameters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename as result or output
|
||
process { | ||
try { | ||
$fabricName = $ReplicationProtectedItem.PrimaryFabricFriendlyName |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add validation for instance type
@@ -155,23 +150,27 @@ function New-AzRecoveryServicesReplicationProtectionContainerMapping { | |||
process { | |||
try { | |||
$replicationscenario = $ProviderSpecificInput.ReplicationScenario | |||
if($replicationscenario -eq "ReplicateAzureToAzure") { | |||
if($replicationscenario -eq "A2A") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's discuss this change once.
Description
Checklist
CONTRIBUTING.md
ChangeLog.md
file(s) has been updated:ChangeLog.md
file can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
## Upcoming Release
header -- no new version header should be added