Skip to content

Commit

Permalink
fix: correct init image tag (#656)
Browse files Browse the repository at this point in the history
  • Loading branch information
smritidahal653 authored Aug 14, 2024
1 parent 67c2bda commit 71660ab
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ TEST_CREDENTIALS_JSON ?= $(TEST_CREDENTIALS_DIR)/credentials.json
TEST_LOGANALYTICS_JSON ?= $(TEST_CREDENTIALS_DIR)/loganalytics.json
export TEST_CREDENTIALS_JSON TEST_LOGANALYTICS_JSON TEST_AKS_CREDENTIALS_JSON

VERSION ?= v1.6.2
VERSION ?= v1.6.1
REGISTRY ?= ghcr.io
IMG_NAME ?= virtual-kubelet
INIT_IMG_NAME ?= init-validation
Expand All @@ -35,7 +35,7 @@ E2E_CLUSTER_NAME := $(CLUSTER_NAME)
OUTPUT_TYPE ?= type=docker
BUILDPLATFORM ?= linux/amd64
IMG_TAG ?= $(subst v,,$(VERSION))
INIT_IMG_TAG ?= v0.3.0
INIT_IMG_TAG ?= 0.2.0

BUILD_DATE ?= $(shell date '+%Y-%m-%dT%H:%M:%S')
VERSION_FLAGS := "-ldflags=-X main.buildVersion=$(IMG_TAG) -X main.buildTime=$(BUILD_DATE)"
Expand Down
2 changes: 1 addition & 1 deletion charts/virtual-kubelet/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ image:
initImage:
repository: mcr.microsoft.com
name: oss/virtual-kubelet/init-validation
initTag: v0.3.0
initTag: 0.3.0
pullPolicy: IfNotPresent

namespace: vk-azure-aci
Expand Down
2 changes: 1 addition & 1 deletion hack/e2e/aks-addon.sh
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ helm install \
--set "image.name=${IMG_REPO}" \
--set "initImage.repository=${IMG_URL}" \
--set "initImage.name=${INIT_IMG_REPO}" \
--set "initImage.tag=${INIT_IMG_TAG}" \
--set "initImage.initTag=${INIT_IMG_TAG}" \
--set "nodeName=${TEST_WINDOWS_NODE_NAME}" \
--set "providers.azure.masterUri=$MASTER_URI" \
--set "providers.azure.managedIdentityID=$ACI_USER_IDENTITY" \
Expand Down
4 changes: 2 additions & 2 deletions hack/e2e/aks.sh
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ helm install \
--set "image.tag=${IMG_TAG}" \
--set "initImage.repository=${IMG_URL}" \
--set "initImage.name=${INIT_IMG_REPO}" \
--set "initImage.tag=${INIT_IMG_TAG}" \
--set "initImage.initTag=${INIT_IMG_TAG}" \
--set "nodeName=${TEST_NODE_NAME}" \
--set providers.azure.vnet.enabled=true \
--set "providers.azure.vnet.subnetName=$ACI_SUBNET_NAME" \
Expand Down Expand Up @@ -216,7 +216,7 @@ helm install \
--set "image.tag=${IMG_TAG}" \
--set "initImage.repository=${IMG_URL}" \
--set "initImage.name=${INIT_IMG_REPO}" \
--set "initImage.tag=${INIT_IMG_TAG}" \
--set "initImage.initTag=${INIT_IMG_TAG}" \
--set "nodeName=${TEST_WINDOWS_NODE_NAME}" \
--set "providers.azure.masterUri=$MASTER_URI" \
"$WIN_CHART_NAME" \
Expand Down

0 comments on commit 71660ab

Please sign in to comment.