Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NSDK-214] Update the WebView URL - Client Specific #127

Open
wants to merge 6 commits into
base: trunk
Choose a base branch
from

Conversation

akueisara
Copy link
Contributor

@akueisara akueisara commented Oct 6, 2024

🔗 Related Links

➡️ To Be

  • Used the store ID to set a different web view URL
  • Removed VirtusizeCore.xcframework. It was a mistake to add it here.
Screen.Recording.2024-10-07.at.1.42.35.mov

☑️ Checklist

  • Useless comments and/or print etc are removed
  • Unit test are covered
  • Code has been deployed and tested on STG
  • ClickUp ticket status has been updated to production
  • Update CHANGELOG.md with the new changes

@akueisara akueisara self-assigned this Oct 6, 2024
Copy link
Contributor

@ourognao ourognao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akueisara 1 comment


private func getWebViewURL() -> URLRequest? {
let storeId = product?.productCheckData?.storeId
if storeId == 99 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Magic number here. It should be defined in a constant file.

let storeData: [String: [String: String]] = [
    "UnitedArrow": [
        "storeId": "99"
    ],
    "leviKorea": [
        "storeId": "XXX"
    ]
]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants