Gen4: groupby support #8453
Merged
Gen4: groupby support #8453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
…if required after horizon planning at top most plan. all select columns to be available irrepective of if they are same expression (for correctness) Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
harshit-gangal
force-pushed
the
gen4-groupby
branch
from
8f81422
to
7809688
Compare
harshit-gangal
added
Component: Query Serving
Type: Enhancement
…eycol in group by params when weight_string is required Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
systay
force-pushed
the
gen4-groupby
branch
3 times, most recently
from
e5fd7fb
to
4b3a655
Compare
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Andres Taylor <andres@planetscale.com>
…group on aggregate functions Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
systay
reviewed
Jul 15, 2021
systay
reviewed
Jul 15, 2021
systay
approved these changes
Jul 15, 2021
frouioui
approved these changes
Jul 15, 2021
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Andres Taylor <andres@planetscale.com>
harshit-gangal
commented
Jul 15, 2021
Comment on lines
+1369
to
+1387
|
|
||
| // ContainsAggregation returns true if the expression contains aggregation | ||
| func ContainsAggregation(e Expr) bool { | ||
| hasAggregates := false | ||
| _ = Walk(func(node SQLNode) (kontinue bool, err error) { | ||
| switch node := node.(type) { | ||
| case *FuncExpr: | ||
| if node.IsAggregate() { | ||
| hasAggregates = true | ||
| return false, nil | ||
| } | ||
| case *GroupConcatExpr: | ||
| hasAggregates = true | ||
| return false, nil | ||
| } | ||
| return true, nil | ||
| }, e) | ||
| return hasAggregates | ||
| } |
There was a problem hiding this comment.
Similar method exists in ordered_aggregates
func nodeHasAggregates(node sqlparser.SQLNode) bool {
hasAggregates := false
_ = sqlparser.Walk(func(node sqlparser.SQLNode) (kontinue bool, err error) {
switch node := node.(type) {
case *sqlparser.FuncExpr:
if node.IsAggregate() {
hasAggregates = true
return false, errors.New("unused error")
}
case *sqlparser.GroupConcatExpr:
hasAggregates = true
return false, errors.New("unused error")
case *sqlparser.Subquery:
// Subqueries are analyzed by themselves.
return false, nil
}
return true, nil
}, node)
return hasAggregates
}
Comment on lines
+141
to
+146
| # join order by with ambiguous column reference ; valid in MySQL | ||
| "select name, name from user, music order by name" | ||
| "ambiguous symbol reference: `name`" | ||
| { | ||
| "QueryType": "SELECT", | ||
| "Original": "select name, name from user, music order by name", |
There was a problem hiding this comment.
this can be moved out from unsupported_cases
Comment on lines
130
to
137
| "Name": "user", | ||
| "Sharded": true | ||
| }, | ||
| "FieldQuery": "select id, weight_string(id) from `user` where 1 != 1", | ||
| "OrderBy": "0 ASC", | ||
| "Query": "select id, weight_string(id) from `user` order by id asc", | ||
| "ResultColumns": 1, | ||
| "FieldQuery": "select id, id, weight_string(id) from `user` where 1 != 1", | ||
| "OrderBy": "(0|2) ASC", | ||
| "Query": "select id, id, weight_string(id) from `user` order by id asc", | ||
| "ResultColumns": 2, | ||
| "Table": "`user`" |
There was a problem hiding this comment.
this can be moved out from unsupported_cases
| @@ -1705,10 +1705,10 @@ Gen4 plan same as above | |||
| } | |||
|
|
|||
| # select from unsharded keyspace into outfile s3 | |||
| "select * from main.unsharded into outfile s3 'out_file_name' character set binary format csv header fields terminated by 'term' optionally enclosed by 'c' escaped by 'e' lines starting by 'a' terminated by '\\n' manifest on overwrite off" | |||
There was a problem hiding this comment.
This looks like an unintentional change.
| @@ -1687,10 +1687,10 @@ Gen4 plan same as above | |||
| } | |||
|
|
|||
| # select from unsharded keyspace into outfile | |||
| "select * from main.unsharded into outfile 'x.txt' character set binary fields terminated by 'term' optionally enclosed by 'c' escaped by 'e' lines starting by 'a' terminated by '\\n'" | |||
There was a problem hiding this comment.
This looks like an unintentional change.
Comment on lines
+40
to
+43
| HasAggr bool | ||
| GroupByExprs []GroupBy | ||
| OrderExprs []OrderBy | ||
| CanPushDownSorting bool |
There was a problem hiding this comment.
hasAggr and CanPushDownSorting should be added in toString method and a test can be added as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for grouping and aggregations.
Gen4 still needs to handle grouping with distinct.
Related Issue(s)
#7280
Checklist
Deployment Notes