Use parameter flags instead of inline flags for regex #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simon-1-1
force-pushed
the
topic/flags-for-regex
branch
2 times, most recently
from
f9f8f6a
to
a29c432
Compare
Using (?i) inside a regex is deprecated. It is still possible to use it at the start of the regex. I consider it clearer to have the flags as parameters instead of inside the regex string. So I set the re.IGNORECASE parameter flag instead. Also added a test for the function where the regex is used.
Simon-1-1
force-pushed
the
topic/flags-for-regex
branch
from
a29c432
to
a38874a
Compare
Simon-1-1
changed the title
Simon-1-1
requested review from
Chloe-KK-Yan
and removed request for
plaos and
nberggr1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the
(?i)inline flag was deprecated in Python 3.6 and raises an error in 3.11.Changed to use parameter flags (
re.IGNORECASE) instead of inline flags.Also added a test for the function where the regex is used.
Reference