Major cleanup of corosync.conf.erb #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corosync.conf.udpu.erb is deleted.
The following params are not defined by default anymore: compatibility,
consensus, join, max_messages, rrp_mode, threads, token,
token_retransmits_before_loss_const, vsftype.
Those parameters can now be specified as class parameters.
New class parameter: vsftype
Logging to file is enabled by default, wrt downstream distributions.
Removed legacy configuration sections: amf, aisexec,
logging.logger_subsys
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
roidelapluie
force-pushed
the
corosync.conf.erb
branch
from
e1e9593
to
62302e0
Compare
| transport: udpu | ||
| <% Array(@unicast_addresses.first).each_index do |interface| -%> | ||
| interface { | ||
| <% Array(Array(@unicast_addresses.map{|x| Array(x).flatten}).transpose[interface]).each do |addr| -%> |
There was a problem hiding this comment.
I'm not sure if we can write this smarter. I'm a bit scared to touch it. It worked in the initial udp conf file so it should be fine as is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
corosync.conf.udpu.erb is deleted.
The following params are not defined by default anymore: compatibility,
consensus, join, max_messages, rrp_mode, threads, token,
token_retransmits_before_loss_const, vsftype.
Those parameters can now be specified as class parameters.
New class parameter: vsftype
Logging to file is enabled by default, wrt downstream distributions.
Removed legacy configuration sections: amf, aisexec, logging.logger_subsys
Signed-off-by: Julien Pivotto roidelapluie@inuits.eu