Multiple improvements for cs_clones #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roidelapluie
force-pushed
the
clone2
branch
15 times, most recently
from
004aac2
to
42a378a
Compare
roidelapluie
changed the title
roidelapluie
force-pushed
the
clone2
branch
2 times, most recently
from
25272db
to
b1fa069
Compare
bastelfreak
requested changes
Sep 16, 2016
| updated << "#{@resource.value(:name)} " | ||
| updated << "#{@resource.should(:primitive)} " | ||
| meta = '' | ||
| { clone_max: 'clone-max', |
There was a problem hiding this comment.
our rubocop config normally marks this. What do you think about inserting a newline after {?
| notify_clones: 'notify', | ||
| globally_unique: 'globally-unique', | ||
| ordered: 'ordered', | ||
| interleave: 'interleave' }.each do |property, clone_property| |
There was a problem hiding this comment.
same here, newline before }?
| PuppetX::Voxpupuli::Corosync::Provider::Pcs.run_command_in_cib(cmd, @resource[:cib]) | ||
| change_clone_id(@property_hash[:primitive], @property_hash[:name], @resource[:cib]) | ||
| cmd = [command(:pcs), 'resource', 'clone', @resource.should(:primitive).to_s] | ||
| { clone_max: 'clone-max', |
There was a problem hiding this comment.
should we change the formatting here too?
| notify_clones: 'notify', | ||
| globally_unique: 'globally-unique', | ||
| ordered: 'ordered', | ||
| interleave: 'interleave' }.each do |property, clone_property| |
roidelapluie
force-pushed
the
clone2
branch
from
b1fa069
to
ee1b8fc
Compare
- Ruby code improvements - Add multiple acceptance tests - Fix changing clone parameters (crm provider) - Purge parameters that are not explicitely set Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
roidelapluie
force-pushed
the
clone2
branch
from
ee1b8fc
to
8bbd1b7
Compare
bastelfreak
approved these changes
Sep 16, 2016
alexjfisher
approved these changes
Sep 16, 2016
alexjfisher
approved these changes
Sep 16, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Julien Pivotto roidelapluie@inuits.eu