Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR#182 addon: arbiter documentation + parameter replset_arbiter for mongodb::server #433

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

pecharmin
Copy link
Contributor

The README currently does not give a hint how to configure an arbiter node for a replica set. That feature has been introduced with pull request #182.
It should also be possible to configure an arbiter by parameter replset_arbiter of mongodb::server.

@bastelfreak bastelfreak reopened this Dec 24, 2017
@bastelfreak
Copy link
Member

Hi @pecharmin, thanks for the PR. Travis had some issues and I restarted the job.

@pecharmin
Copy link
Contributor Author

@bastelfreak The Travis jobs still seem broken caused by ruby errors during bundle. Can you please have a look at them?

@bastelfreak
Copy link
Member

@pecharmin the errors were caused by issues on the CI platform. Can you please rebase?

@@ -53,6 +53,7 @@
Optional[String] $replset = undef,
Optional[Hash] $replset_config = undef,
Optional[Array] $replset_members = undef,
Optional[String] $replset_arbiter = undef,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update this to:

Suggested change
Optional[String] $replset_arbiter = undef,
Optional[String[1]] $replset_arbiter = undef,

@bastelfreak
Copy link
Member

@pecharmin can you please take a look at the failing spec tests and rebase against our current master branch?

@guikcd
Copy link

guikcd commented Feb 17, 2020

Only failing because arbiter is nil instead of expected undef 🤔

@vox-pupuli-tasks
Copy link

Dear @pecharmin, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants