Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing Amazon Linux 2 support #23

Merged
merged 4 commits into from
Feb 16, 2024

Conversation

erik-frontify
Copy link

Fixes #21

Not sure if it was meant to support the "old" Amazon linux as well but with this patch it will at least support Amazon linux 2 as the error message implies.

@zilchms
Copy link

zilchms commented Feb 16, 2024

Hey @erik-frontify,
I know this is a bit late. Stumbled over this PR and your issue. I have done some maintainence on this module, can you let me know if this PR is still needed? If so, would you be willing to rebase this and adapt to make it fit? :)

@erik-frontify
Copy link
Author

@zilchms Thank you for looking into this. Yes, I'd say that's still needed. We just use my fork, currently, but happy to switch to the new release once this is included.

Sorry, I just figured that the whole switch case for Amazon Linux doesn't make sense any more as Amazon Linux 2 is similar to the RedHat default
@erik-frontify
Copy link
Author

Just figured it's not needed any more, as Amazon Linux 2 is similar to RedHat default.

@zilchms zilchms added the enhancement New feature or request label Feb 16, 2024
@zilchms zilchms merged commit 173c9a2 into voxpupuli:master Feb 16, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants